Skip to content

Bump @tanstack/react-virtual #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RobinMalfait merged 1 commit into from
Dec 12, 2024
Merged

Bump @tanstack/react-virtual #3588

RobinMalfait merged 1 commit into from
Dec 12, 2024

Conversation

@kchung
Copy link
Contributor

@kchung kchung commented Dec 10, 2024

@tanstack/react-virtual added peer deps support for React 19 in v3.11.0 (TanStack/virtual#893)

This PR upgrades the packages. This can resolve some warnings on some React 19 projects, e.g.:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @tanstack/react-virtual@3.10.9
npm warn Found: react@19.0.0
npm warn node_modules/react
npm warn   peer react@"^18 || ^19 || ^19.0.0-rc" from @headlessui/react@2.2.0
npm warn   node_modules/@headlessui/react
npm warn     @headlessui/react@"^2.2.0" from the root project
npm warn   15 more (@floating-ui/react, @floating-ui/react-dom, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9
npm warn node_modules/@headlessui/react/node_modules/@tanstack/react-virtual
npm warn   @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0
npm warn   node_modules/@headlessui/react
npm warn
npm warn Conflicting peer dependency: react@18.3.1
npm warn node_modules/react
npm warn   peer react@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9
npm warn   node_modules/@headlessui/react/node_modules/@tanstack/react-virtual
npm warn     @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0
npm warn     node_modules/@headlessui/react
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @tanstack/react-virtual@3.10.9
npm warn Found: react-dom@19.0.0
npm warn node_modules/react-dom
npm warn   peer react-dom@"^18 || ^19 || ^19.0.0-rc" from @headlessui/react@2.2.0
npm warn   node_modules/@headlessui/react
npm warn     @headlessui/react@"^2.2.0" from the root project
npm warn   5 more (@floating-ui/react, @floating-ui/react-dom, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react-dom@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9
npm warn node_modules/@headlessui/react/node_modules/@tanstack/react-virtual
npm warn   @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0
npm warn   node_modules/@headlessui/react
npm warn
npm warn Conflicting peer dependency: react-dom@18.3.1
npm warn node_modules/react-dom
npm warn   peer react-dom@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9
npm warn   node_modules/@headlessui/react/node_modules/@tanstack/react-virtual
npm warn     @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0
npm warn     node_modules/@headlessui/react

@vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:44am
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:44am

@RobinMalfait RobinMalfait merged commit 058a14b into tailwindlabs:main Dec 12, 2024
8 checks passed
@RobinMalfait
Copy link
Member

RobinMalfait commented Dec 12, 2024

Hey, thanks so much for this contribution! 🙏

@kchung kchung deleted the update-react-virtual branch December 12, 2024 18:24
@jdwitten
Copy link

jdwitten commented Jan 13, 2025

Has this change been released? I was confused because I saw it was on the main branch but still getting errors in my project on v2.2.0

@dd-jonas
Copy link

dd-jonas commented Feb 27, 2025

Hi @RobinMalfait, is there a release planned which includes this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kchung @RobinMalfait @jdwitten @dd-jonas